Added Huggingface model transfer class with save_pretrained in download #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarleneKress79789
force-pushed
the
feature/#143_Add_model_transfer_with_save_pretrained
branch
from
be1b5c7 to
c4f22e0
Compare
…with_save_pretrained' into feature/#143_Add_model_transfer_with_save_pretrained
MarleneKress79789
force-pushed
the
feature/#143_Add_model_transfer_with_save_pretrained
branch
from
39bce56 to
cdcccc7
Compare
…with_save_pretrained' into feature/#143_Add_model_transfer_with_save_pretrained
tkilias
reviewed
Nov 29, 2023
exasol_transformers_extension/utils/huggingface_hub_bucketfs_model_transfer_sp.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Nov 29, 2023
exasol_transformers_extension/utils/huggingface_hub_bucketfs_model_transfer_sp.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Nov 29, 2023
exasol_transformers_extension/utils/huggingface_hub_bucketfs_model_transfer_sp.py
Outdated
Show resolved
Hide resolved
tkilias
previously requested changes
Dec 15, 2023
|
|
||
|
|
||
| @runtime_checkable | ||
| class ModelFactoryProtocol(Protocol): |
There was a problem hiding this comment.
I think that got duplicated, extract from both files and use the same
exasol_transformers_extension/utils/huggingface_hub_bucketfs_model_transfer_sp.py
Outdated
Show resolved
Hide resolved
| self.bucketfs_location_mock.reset_mock() | ||
| self.temporary_directory_factory_mock.reset_mock() | ||
| self.model_factory_mock.reset_mock() | ||
| self.bucketfs_model_uploader_mock.reset_mock() |
There was a problem hiding this comment.
self.bucketfs_model_uploader_factory_mock is missing
| def test_download_function_call(): | ||
| test_setup = TestSetup() | ||
| test_setup.downloader.download_from_huggingface_hub(model_factory=test_setup.model_factory_mock) | ||
| cache_dir = test_setup.temporary_directory_factory_mock.create().__enter__() |
There was a problem hiding this comment.
Suggested change
| cache_dir = test_setup.temporary_directory_factory_mock.create().__enter__() | |
| cache_dir = mock_cast(test_setup.temporary_directory_factory_mock.create().__enter__).return_value |
There was a problem hiding this comment.
otherwise you are adding a call to the mocks mock_calls
| test_setup = TestSetup() | ||
| test_setup.downloader.download_from_huggingface_hub(model_factory=test_setup.model_factory_mock) | ||
| cache_dir = test_setup.temporary_directory_factory_mock.create().__enter__() | ||
| model_save_path = (test_setup.downloader._tmpdir_name/"pretrained"/test_setup.model_name) |
There was a problem hiding this comment.
you should not access private attributes, why do you need it?
tests/unit_tests/utils/test_huggingface_hub_bucketfs_model_transfer_sp.py
Show resolved
Hide resolved
tests/unit_tests/utils/test_huggingface_hub_bucketfs_model_transfer_sp.py
Outdated
Show resolved
Hide resolved
kaklakariada
approved these changes
Dec 19, 2023
kaklakariada
dismissed
tkilias’s stale review
Team member currently not available, all findings are fixed.
MarleneKress79789
deleted the
feature/#143_Add_model_transfer_with_save_pretrained
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
[CodeBuild]to the commit messageFixes #143