Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#126: Add documentation for token for private models in prediction UDFs #127

Merged
merged 5 commits into from
Sep 8, 2023
Merged

#126: Add documentation for token for private models in prediction UDFs #127

merged 5 commits into from
Sep 8, 2023

Conversation

tkilias
Copy link
Collaborator

@tkilias tkilias commented Sep 8, 2023 •
edited
Loading

Fixes #126

All Submissions:

  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")
  • Before you merge don't forget to run tests in AWS CodeBuild, by adding [CodeBuild] to the commit message

@ahsimb ahsimb self-requested a review September 8, 2023 14:48
ahsimb
ahsimb previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@ahsimb ahsimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really pick anything apart from very small re-wording in one place.

doc/changes/changes_0.5.0.md Outdated Show resolved Hide resolved
tkilias
tkilias commented Sep 8, 2023
View reviewed changes
doc/changes/changes_0.5.0.md Outdated Show resolved Hide resolved
@tkilias tkilias merged commit c82c6f1 into main Sep 8, 2023
@MarleneKress79789 MarleneKress79789 deleted the documentation/126_add_docu_for_token branch October 11, 2023 13:12
tomuben added a commit that referenced this pull request Jun 13, 2024
@tomuben
#127: Fixed reference to python-extension-common
bd4b175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsimb ahsimb ahsimb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for token for private models in prediction UDFs
2 participants
@tkilias @ahsimb