Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
suggestions from code review

Co-authored-by: Torsten Kilias <[email protected]>
  • Loading branch information
MarleneKress79789 and tkilias authored Oct 30, 2023
1 parent 1bbc4bf commit 2006d2d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions tests/unit_tests/udfs/base_model_dummy_implementation.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def __init__(self,

def extract_unique_param_based_dataframes(
self, model_df: pd.DataFrame) -> Iterator[pd.DataFrame]:

yield model_df

def execute_prediction(self, model_df: pd.DataFrame) -> \
Expand All @@ -32,7 +31,6 @@ def append_predictions_to_input_dataframe(
self, model_df: pd.DataFrame, pred_df_list: List[pd.DataFrame]) \
-> pd.DataFrame:

# Concat predictions and model_df
pred_df = pd.concat(pred_df_list, axis=0).reset_index(drop=True)
model_df = pd.concat([model_df, pred_df], axis=1)
return model_df
Expand Down
1 change: 0 additions & 1 deletion tests/unit_tests/udfs/test_base_udf.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ def test_model_downloader_missing_parameters(description, bucketfs_conn_name, bu

udf.run(mock_ctx)
res = mock_ctx.output
print(res)
error_field = res[0][-1]
expected_error_start = f"For each model model_name, bucketfs_conn and sub_dir need to be provided. " \
f"Found model_name = {model_name},"
Expand Down

0 comments on commit 2006d2d

Please sign in to comment.