Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies 2023-03-22 #319

Merged
merged 9 commits into from
Mar 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
- pyodbc
- turbodbc
exasol_version:
- 7.1.9
- 7.0.18
- 7.1.17
- 7.0.20

name: Integration Tests (Python-${{ matrix.python }}, Connector-${{ matrix.connector }}, Exasol-${{ matrix.exasol_version }})

Expand All @@ -87,13 +87,6 @@ jobs:
run: poetry install --extras "turbodbc"
if: ${{ matrix.connector == 'turbodbc' }}

- name: Checkout test environment
run: git clone --depth 1 --branch ${ITDE_TAG} ${ITDE_URL}
working-directory: ..
env:
ITDE_URL: "https://github.com/exasol/integration-test-docker-environment.git"
ITDE_TAG: "0.11.0"

- name: Run Test for Python ${{ matrix.python }} using ${{ matrix.connector }}
run: |
poetry run nox -s unit-tests
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ jobs:
- pyodbc
- turbodbc
exasol_version:
- 7.1.9
- 7.0.18
- 7.1.17
- 7.0.20

name: Integration Tests (Python-${{ matrix.python }}, Connector-${{ matrix.connector }}, Exasol-${{ matrix.exasol_version }})

Expand All @@ -91,13 +91,6 @@ jobs:
run: poetry install --extras "turbodbc"
if: ${{ matrix.connector == 'turbodbc' }}

- name: Checkout test environment
run: git clone --depth 1 --branch ${ITDE_TAG} ${ITDE_URL}
working-directory: ..
env:
ITDE_URL: "https://github.com/exasol/integration-test-docker-environment.git"
ITDE_TAG: "0.11.0"

- name: Run Test for Python ${{ matrix.python }} using ${{ matrix.connector }}
run: |
poetry run nox -s unit-tests
Expand Down
10 changes: 5 additions & 5 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Unreleased
✨ Added
--------

* Add websocket based dbapi2 compliant database driver
* Added websocket based dbapi2 compliant database driver

🔧 Changed
----------
Expand All @@ -27,17 +27,17 @@ Unreleased

🧰 Internal
-----------
* Change changelog workflow
* Changed changelog workflow

- Removed scriv
- Added unreleased section to track unreleased changes

* Simplified workflows by factoring out python & poetry setup into an action
* Add an internal category to the changelog fragment template
* Add a manual trigger for the gh-pages workflow
* Added a internal category to the changelog fragment template
* Added manual trigger for the gh-pages workflow
* Removed workaround for outdated DB versions
(for further details see https://github.com/exasol/sqlalchemy-exasol/issues/5)

* Added exasol-integration-test-docker-environment as dev dependency

.. _changelog-4.0.0:

Expand Down
39 changes: 17 additions & 22 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from typing import Iterator

import nox
from git import tags
from git_helpers import tags
from links import check as _check
from links import documentation as _documentation
from links import urls as _urls
Expand All @@ -40,14 +40,13 @@


class Settings:
ITDE = PROJECT_ROOT / ".." / "integration-test-docker-environment"
ODBC_DRIVER = PROJECT_ROOT / "driver" / "libexaodbc-uo2214lv2.so"
CONNECTORS = ("pyodbc", "turbodbc")
ENVIRONMENT_NAME = "test"
DB_PORT = 8888
BUCKETFS_PORT = 6666
VERSION_FILE = PROJECT_ROOT / "sqlalchemy_exasol" / "version.py"
DB_VERSIONS = ("7.1.9", "7.0.18")
DB_VERSIONS = ("7.1.17", "7.0.20")


def find_session_runner(session: Session, name: str) -> SessionRunner:
Expand Down Expand Up @@ -135,24 +134,21 @@ def parser() -> ArgumentParser:
return p

def start(db_version: str) -> None:
# Consider adding ITDE as dev dependency once ITDE is packaged properly
with session.chdir(Settings.ITDE):
session.run(
"bash",
"start-test-env",
"spawn-test-environment",
"--environment-name",
f"{Settings.ENVIRONMENT_NAME}",
"--database-port-forward",
f"{Settings.DB_PORT}",
"--bucketfs-port-forward",
f"{Settings.BUCKETFS_PORT}",
"--docker-db-image-version",
db_version,
"--db-mem-size",
"4GB",
external=True,
)
session.run(
"itde",
"spawn-test-environment",
"--environment-name",
f"{Settings.ENVIRONMENT_NAME}",
"--database-port-forward",
f"{Settings.DB_PORT}",
"--bucketfs-port-forward",
f"{Settings.BUCKETFS_PORT}",
"--docker-db-image-version",
db_version,
"--db-mem-size",
"4GB",
external=True,
)

args = parser().parse_args(session.posargs)
start(args.db_version)
Expand All @@ -162,7 +158,6 @@ def start(db_version: str) -> None:
def stop_db(session: Session) -> None:
"""Stop the test database"""
session.run("docker", "kill", "db_container_test", external=True)
session.run("docker", "kill", "test_container_test", external=True)


@nox.session(name="sqla-tests", python=False)
Expand Down
Loading