Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple lines at once in LogHandlers #2

Merged
merged 1 commit into from
May 5, 2020

Conversation

tkilias
Copy link
Contributor

@tkilias tkilias commented May 5, 2020

Docker on MacOSX seems to return multiple lines at once when streaming API call logs. This patch extends the API of all LogHandlers with the function handle_log_lines to accept multiple lines. The AbstractLogHandler does the decoding and splitting of the lines and feeds them into the method handle_log_line.
The DockerRegistryImageChecker used before its own method to parse the log, it now uses a specific implementation of the LogHandler which simplifies this step.

@tkilias tkilias merged commit 73b649a into master May 5, 2020
@tkilias tkilias deleted the bug/patch_log_handler branch June 12, 2020 10:27
MarleneKress79789 added a commit that referenced this pull request May 13, 2022
# This is the 1st commit message:

updated minimal python version to 3.8

# This is the commit message #2:

new checksum

# This is the commit message #3:

install python 3.8 in dockerfile
ckunki added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant