Skip to content
This repository was archived by the owner on Sep 26, 2022. It is now read-only.

Correct mock bucketfs upload method #63

Closed
umitbuyuksahin opened this issue May 5, 2022 · 2 comments · Fixed by #65
Closed

Correct mock bucketfs upload method #63

umitbuyuksahin opened this issue May 5, 2022 · 2 comments · Fixed by #65
Assignees
Labels
bug Unwanted / harmful behavior source:exasol Issue was created on behalf of the organization

Comments

@umitbuyuksahin
Copy link
Contributor

umitbuyuksahin commented May 5, 2022

Background

  • An infinite loop occurs, while reading a file object chunk by chunk in the line shown below.
  • The reason of the infinite loop is that the senitel character of the iter method is not correct. It should be b'', instead of ' '.

for chunk in iter(lambda: fileobj.read(10000), ''):

Acceptance Criteria

  • Fixed the error
  • Add unit tests regarding this method
@umitbuyuksahin umitbuyuksahin added bug Unwanted / harmful behavior source:exasol Issue was created on behalf of the organization labels May 5, 2022
@tkilias
Copy link
Contributor

tkilias commented May 5, 2022

Do you mean b'' or b' '?

@umitbuyuksahin
Copy link
Contributor Author

umitbuyuksahin commented May 5, 2022

it is a typo, it must be b''

@umitbuyuksahin umitbuyuksahin self-assigned this May 9, 2022
github-actions bot pushed a commit that referenced this issue May 11, 2022
…s-upload-method' with commit id '215f80310bd1aec4c9fbc77a27a17312da1c3647'
umitbuyuksahin added a commit that referenced this issue May 11, 2022
* Corrected the mock upload fileobj method

* Updated changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Unwanted / harmful behavior source:exasol Issue was created on behalf of the organization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants