Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/statement logs #747

Closed
wants to merge 13 commits into from
Closed

Conversation

jean-humann
Copy link
Contributor

No description provided.

@Minutis
Copy link
Member

Minutis commented Nov 15, 2023

Hi,

thank your for initiative to contribute to this project. Could you please provide some information regarding the change you made?

IMAGE_NAME: ${{ github.repository }}
runs-on: ubuntu-latest
strategy:
matrix:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to extract matrix to a single file ind include it on all workflows, that require it, if its possible.

BASE_REF: ${{ env.BASE_REF }}
run: |
TAG_TO_DELETE=${IMAGE_NAME}:${BASE_REF}-spark${{ matrix.spark_version }}
TOKEN=$(echo "${TOKEN}" | awk '{print substr($0, 12)}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

@pdambrauskas
Copy link
Collaborator

Pipeline is failing:

#30 ERROR: failed to push ghcr.io/exacaster/lighter:fix-statement-logs-spark3.3.3: unexpected status from POST request to https://ghcr.io/v2/exacaster/lighter/blobs/uploads/: 403 Forbidden

Something is wrong with the authorization

@pdambrauskas
Copy link
Collaborator

I've cherry-picked commits related to the fix. Regarding CI changes, we've chosen a different approach for selectively building images from Pull requests.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants