Add matrix strategy for CI + fix for Click 7.x. #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112, and lays groundwork for resolving #18.
Overview
I was working on resolving #18 when I noticed that the solution to this involves branching logic for Click 8 and Click 7.
I also noticed this library is getting more popular (congrats!) and people are starting to use it for more things.
In light of all this, I thought that before I address #18, I should significantly expand the scope of the CI so that all versions of Click that you say are supported, actually are supported.
Uncovering some regressions with Click 7.x support
In doing this, I discovered that the latest version of the code base in
main
actually has quite a few Click 7.x regressions.In this code, I've fixed every regression I could see, except support for
rich_config
, which I could not get working.Some of the regression fixes aren't the prettiest, but the fixes appear to work just fine.
Where to go from here
I feel like you can either keep as is, or you can add deprecation warnings for support to click 7.x and then remove that support in a future release.