Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assemblyscript #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add assemblyscript #6

wants to merge 1 commit into from

Conversation

poemm
Copy link

@poemm poemm commented Mar 24, 2019

Add AssemblyScript source code and compiled wasm. This is @lrettig 's work, I just copied files.

@jwasinger
Copy link

Should probably amend the commit to make @lrettig an author.

@poemm poemm force-pushed the AssemblyScript branch from c9790d3 to a282313 Compare May 9, 2019 23:44
@poemm
Copy link
Author

poemm commented May 9, 2019

Amended with author change.

BTW anyone is welcome to update this code. I think that Lane mentioned that he ignored endianness so input/output may need bytes reversed, and that he doesn't know whether it still compiles with newest Assemblyscript compiler.

@hugo-dc
Copy link
Member

hugo-dc commented May 10, 2019

I tried this code, there are some issues with endianess. Maybe we can merge this and then fix it. I made some changes and pushed to this repo: https://github.com/hugo-dc/wrc20-as/blob/master/assembly/index.ts

I fixed the function selector endianess and added the namespace decorators, iirc it is still returning the values with reversed endianess.

Maybe we could merge this PR, and then fix it to use correct endianness.

@poemm
Copy link
Author

poemm commented May 10, 2019

Should this repository contain source code or just a spec, a test framework, and links to source code? I expect that not everyone will want to share their source code here for various reasons.

So maybe this PR should be closed in favor of a separate AssemblyScript_Ewasm_Contracts repo. Any thoughts?

@lrettig
Copy link
Member

lrettig commented May 12, 2019

Happy to take another look at this but holding off for now pending @poemm's question here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants