This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
trace before gas charge is applied #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
previously approved these changes
Apr 27, 2018
axic
reviewed
Apr 27, 2018
| @@ -182,6 +182,11 @@ exports.evm2wast = function (evmCode, opts = { | |||
| const opint = evmCode[pc] | |||
| const op = opcodes(opint) | |||
|
|
|||
| // creates a stack trace | |||
| if (opts.stackTrace) { | |||
| segment += `(call $stackTrace (i32.const ${pc}) (i32.const ${opint}) (i32.const ${gasCount}) (get_global $sp))\n` | |||
There was a problem hiding this comment.
The linked issue shows that gasCount here should be the actual gas usage of the instruction, but here this value is always 0 after this change.
There was a problem hiding this comment.
What do you mean gasCount is always zero? gasCount gets updated every iteration of the loop.
There was a problem hiding this comment.
gasCount here means gas left. Not the cost of the opcode.
There was a problem hiding this comment.
Ah ok, missed it was a for loop, sorry.
axic
approved these changes
Apr 30, 2018
|
Please fix the test failure: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be compliant with the standard trace format: ethereum/tests#249