Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion (<del>) is not rendered if the number (@n) of the line is added. #112

Closed
federicaspinelli opened this issue Jan 22, 2021 · 2 comments

Comments

@federicaspinelli
Copy link
Contributor

federicaspinelli commented Jan 22, 2021

When using both <note> and <del> in lines of poetry, if we give the line an @n, the inline note marker appears but the deletion is not rendered in EVT. If we remove the @n from <l>, the <del> is rendered but the note marker disappears and the <note> text appears inline.

This is a sample TEI encoding:

<l n="7">To hear<note>blah blah</note> the wild wind <del>rushing</del> by</l>
<l>With<note>yadda yadda</note> never <del>ending</del> roar;</l>

and in the attached image you can see how EVT 2 beta2 renders it:

image001

@RobertoRDT
Copy link
Member

Adding the sample files included in the original mail by Justin Tonra (2021-01-22).

EVT del query.zip

@ChiaraDipi
Copy link
Member

ChiaraDipi commented Jan 25, 2021

In reality the problem is reversed: in lines without @n attribute, for some reason nested children are not correctly parsed and rendered; when adding the @n attribute nested children are instead correctly parsed (that's why the notes works properly), but some elements are not rendered as expected.

If you analyze the HTML you'll see that both <note> and <del> are not correctly transformed into <span>s. del seems to be correctly rendered because this is the browser's default rendering for the html element <del>.

In the line with @n the xml element is almost correctly transformed: there is just a problem with the class name: it is all uppercase thus it does not follows the rules defined for the element with class .del (all smallcase). We should fix also this problem.

Anyway if you want, you can add your own style rule like:

.DEL {
   text-decoration: line-through;
}

More over, even for .del elements, in critical edition there is a rule which remove this particular layout.

babsevensix pushed a commit to babsevensix/evt-viewer that referenced this issue Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants