Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVT is only loading the last rule of each item because getLayouts() overwrites the object at every cycle with the default values from editorial-conventions.service.ts.
Below the json used for the test. It's taken from the readme with minimum editing.
For example without this fix, the first group of rules stored in "diplomatic" for element 'add' are ignored and the default rules hardcoded applied instead.
FIX:
Since default keys are already placed in the output layout at its initialization
let layouts: Partial<EditorialConventionLayouts> = defaultKeys;
there's no need to load them again at every cycle and we can simply spread the new properties from external layout.