Use ansible_facts instead of global scoped variables #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the include_vars is relying on the full hostvars which can slow down the role execution. Instead, load the right (recommended) variables. At the same time, the use a first_found lookup instead of a with_first_found loop allows the 'paths' parameter to be used. This ensures that only vars from the role are included, and not vars from a parent calling role. This can happen when a parent role has a higher priority vars file available for inclusion than the role it calls.
With previous patch, the ansible_facts were only used for the include_vars. This is a problem, as we don't get the full benefit of moving towards ansible_facts. This should fix it by ensuring the role is using ansible_facts everywhere necessary.
evrardjp
force-pushed
the
update_include_vars_to_recent_practices
branch
from
3392451 to
95a8ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.