Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide custom labels in metrics #453

Conversation

BrainHorse
Copy link
Contributor

Sometimes it is more convenient to show metrics based on their labels rather than their names

@BrainHorse BrainHorse requested a review from Z1kkurat November 20, 2024 15:05
(prometheusKey -> value).some
else None
}
val (customLabelsKeys, customLabelsValues) = customLabels.separate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it doesn't have to be called on each collect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, changed

@Z1kkurat Z1kkurat merged commit 07d7860 into evolution-gaming:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants