update inline strategy #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR :) Can you fix up the lint issues and I'll rerun the CI. |
|
Ah, forgot the tests |
|
Sorry, I'm on mobile 😅 |
|
I'm not sure what would have changed to cause the embroider optimized scenario to fail 😐 |
|
2.4.3 broke our application's svgs as well. I have confirmed that this PR fixes our issue. Looking forward to its merge. |
|
I think this should be safe to merge but I want to do a little digging to see why the test is failing. |
|
I tried running the tests on the master branch and saw the same issue. Something outside of this repo has changed causing this failure, so I'm just going to merge and cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #253