Use uniqueId for recurring title and desc
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses `guidFor` this will cache ids and reuse them if the same value is passed to `guidFor`, see https://github.com/emberjs/ember.js/blob/4e3300bdfe75da14f9714b6b1539dbd1612c5af2/packages/%40ember/-internals/utils/lib/guid.ts#L97 The ids in a HTML document should be unique. However if a `title` or `desc` is reused, for example you have a recurring element, then `svg-jar` generates ids which match for the recurring element. This commit uses the `uniqueId` function from the `unique-id` helper to generate a unique id regardless of the `svg-jar` `title` or `desc` matching previous `svg-jar`. Unfortunately `uniqueId` is not exported so it is copy and pasted. In the future it will be possible to import it, see emberjs/ember.js#20165 Fixes evoactivity#243
jherdman
approved these changes
Nov 29, 2022
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses
guidForthis will cache ids and reuse them if the same value is passed toguidFor, see https://github.com/emberjs/ember.js/blob/4e3300bdfe75da14f9714b6b1539dbd1612c5af2/packages/%40ember/-internals/utils/lib/guid.ts#L97The ids in a HTML document should be unique. However if a
titleordescis reused, for example you have a recurring element, thensvg-jargenerates ids which match for the recurring element.This commit uses the
uniqueIdfunction from theunique-idhelper to generate a unique id regardless of thesvg-jartitleordescmatching previoussvg-jar.Unfortunately
uniqueIdis not exported so it is copy and pasted. In the future it will be possible to import it, see emberjs/ember.js#20165Fixes #243