Issue49 Query Results Post Processing #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2019 15:44
SamHard
changed the title
|
The more I think about it, the more I think this is the wrong direction. The main thing is that this hack won't work if the GraphClient constructor accepting an IGremlinClient is used, and there is a pull request (PR 56) proposing to make that constructor public. We'd be better off rolling back to an older version of Gremlin.Net, as proposed in pull request 51, until we can fix Gremlin.Net. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the breaking changes referenced in #49 by doing the processing that used to be done in Gremlin.Net after the fact. It's not pretty, but it allows us to keep more up-to-date with the Gremlin.Net library.