🐛 Fix: Procedures imports #1202
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fba6d7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 57 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 178 files out of 235 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThe updates include critical patches and alterations across several packages within the Changes
Sequence Diagram(s)Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @roninjin10 and the rest of your teammates on |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .changeset/hip-ducks-know.md (1 hunks)
- .changeset/pink-tigers-grin.md (1 hunks)
- packages/procedures/src/requestBulkProcedure.js (1 hunks)
- packages/procedures/src/requestProcedure.js (32 hunks)
- packages/procedures/src/requestProcedure.spec.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/pink-tigers-grin.md
Additional comments not posted (6)
.changeset/hip-ducks-know.md (1)
1-5: The changeset description is clear and accurately describes the patch for the@tevm/procedurespackage.packages/procedures/src/requestBulkProcedure.js (2)
Line range hint
1-1: Updated import path correctly reflects the new file structure.
5-5: Ensure the return type path in JSDoc comments is updated to reflect the new import paths.packages/procedures/src/requestProcedure.spec.ts (1)
9-9: Consolidation of imports improves clarity and reduces redundancy.packages/procedures/src/requestProcedure.js (2)
62-62: Update return type documentation to match new import path.The updated return type documentation reflects the new import path accurately, aligning with the PR's objective to fix procedure imports.
143-143: Ensure new import paths are correctly implemented across various request handlers.The changes in import paths across various request handlers are consistent with the PR's goal to update and correct them. This should resolve the import path issues noted in the PR description.
Also applies to: 161-161, 184-184, 206-206, 249-249, 267-267, 282-284, 359-359, 398-398, 404-404, 410-410, 425-425, 467-467, 481-481, 512-512, 560-560, 586-586, 660-660, 682-682, 717-719, 755-755, 860-860, 893-893, 940-940, 1050-1050, 1105-1105, 1138-1138, 1169-1169, 1248-1248
| @@ -2,7 +2,7 @@ import { requestProcedure } from './requestProcedure.js' | |||
|
|
|||
| /** | |||
| * @param {import('@tevm/base-client').BaseClient} client | |||
| * @returns {import('@tevm/procedures').TevmJsonRpcBulkRequestHandler} | |||
| * @returns {import('./tevm-request-handler/TevmJsonRpcBulkRequestHandler.js').TevmJsonRpcBulkRequestHandler} | |||
There was a problem hiding this comment.
The function handles bulk requests robustly using Promise.allSettled. Consider formalizing the tracking of the TODO regarding error handling enhancements.
Would you like me to open a GitHub issue to track the addition of UnexpectedBulkRequestError to the @tevm/errors package?
roninjin10
force-pushed
the
06-14-_bug_fix_procedures_imports
branch
from
bcefd33 to
fba6d7a
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4b5b546`](4b5b546)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4b5b546`](4b5b546)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4b5b546`](4b5b546)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - [#1202](#1202) [`4b5b546`](4b5b546) Thanks [@roninjin10](https://github.com/roninjin10)! - Fixed bug with imports not being updated in procedures package - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`cae3703`](cae3703)]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - [#1203](#1203) [`cae3703`](cae3703) Thanks [@roninjin10](https://github.com/roninjin10)! - Fix bad package.json type ## [email protected] ### Patch Changes - Updated dependencies \[[`4b5b546`](4b5b546)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information
Your ENS/address:
Summary by CodeRabbit
Bug Fixes
Chores
tevmpackages, including updates to bundlers, plugins, compilers, and utilities.