-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intrarelayer changes from spec #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Validate genesis fix. genesis and params tests * initial structure for msg and proposal tests * testing: proposal tests addeds * testing: update token pair erc20 with invalid addresses * token pair and msgs test Co-authored-by: ramacarlucho <[email protected]>
* merge irms branchs * Fix pack method * removed valid test from TestRegisterTokenPair, this should be tested on TestRegisterTokenPairWithContract * using ethermint CompiledContract * removed unused import * unpacking using interfaces * Update x/intrarelayer/types/contracts/erc20.go Co-authored-by: Federico Kunze Küllmer <[email protected]> * moved evm types to types folder * feemarket enabled by default on test suite * contracts function and test setup moved to keeper_test Co-authored-by: Federico Kunze Küllmer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
===========================================
+ Coverage 62.53% 74.47% +11.93%
===========================================
Files 4 22 +18
Lines 638 1610 +972
===========================================
+ Hits 399 1199 +800
- Misses 228 354 +126
- Partials 11 57 +46
|
fedekunze
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
November 16, 2021 17:00
This pull request introduces 1 alert when merging ed8f3d7 into 6003aca - view on LGTM.com new alerts:
|
fedekunze
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work guys!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)