Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: boilerplate for IBC modules #412

Merged
merged 7 commits into from
Mar 21, 2022
Merged

imp: boilerplate for IBC modules #412

merged 7 commits into from
Mar 21, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Mar 21, 2022

Description

Closes: ENG-85


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #412 (f4f4fd6) into main (646f259) will increase coverage by 0.26%.
The diff coverage is 91.80%.

❗ Current head f4f4fd6 differs from pull request most recent head 93caec8. Consider uploading reports for the commit 93caec8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   78.65%   78.91%   +0.26%     
==========================================
  Files          97       99       +2     
  Lines        5579     5592      +13     
==========================================
+ Hits         4388     4413      +25     
+ Misses       1035     1022      -13     
- Partials      156      157       +1     
Impacted Files Coverage Δ
x/claims/ibc_module.go 27.77% <33.33%> (+12.62%) ⬆️
types/utils.go 90.32% <76.92%> (-9.68%) ⬇️
ibc/module.go 100.00% <100.00%> (ø)
ibc/utils.go 100.00% <100.00%> (ø)
x/claims/keeper/ibc_callbacks.go 87.90% <100.00%> (-1.83%) ⬇️

@github-actions github-actions bot added the types label Mar 21, 2022
@linear
Copy link

linear bot commented Mar 21, 2022

ENG-85 IBC module boilerplate interface

Create an IBC boilerplate in order to reduce code maintenance

@fedekunze fedekunze marked this pull request as ready for review March 21, 2022 17:50

module := NewModule(mockModule)

// mock calls for abstraction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can clarify that these are all pretty much no-ops

x/claims/keeper/ibc_callbacks.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) March 21, 2022 19:39
@fedekunze fedekunze merged commit e5075b3 into main Mar 21, 2022
@fedekunze fedekunze deleted the fedekunze/ibc-boilerplate branch March 21, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants