Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(erc-20): Compile built-in contracts in the build process (IF-ETHERMINT-02) #201

Merged
merged 7 commits into from
Jan 10, 2022
Merged

bug(erc-20): Compile built-in contracts in the build process (IF-ETHERMINT-02) #201

merged 7 commits into from
Jan 10, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Jan 7, 2022

No description provided.

@linear
Copy link

linear bot commented Jan 7, 2022

ENG-373 IF-ETHERMINT-02: Compile built-in contracts in the build process

Compile ERC20Burnable, ERC20MinterBurner, and ERC20PresetMinterPauser contracts from their Solidity sources
as part of the build process. This would increase transparency of the built-in contracts and allow the developers to
peer-review the changes in the contracts.

fedekunze
fedekunze approved these changes Jan 10, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@danburck danburck changed the title bug(erc-20): Add ERC20MinterBurnerDecimals bug(erc-20): IF-ETHERMINT-02: Compile built-in contracts in the build process Jan 10, 2022
@danburck danburck changed the title bug(erc-20): IF-ETHERMINT-02: Compile built-in contracts in the build process bug(erc-20): Compile built-in contracts in the build process IF-ETHERMINT-02 Jan 10, 2022
@danburck danburck changed the title bug(erc-20): Compile built-in contracts in the build process IF-ETHERMINT-02 bug(erc-20): Compile built-in contracts in the build process (IF-ETHERMINT-02) Jan 10, 2022
@danburck danburck marked this pull request as ready for review January 10, 2022 16:14
@danburck danburck enabled auto-merge (squash) January 10, 2022 16:14
@danburck danburck merged commit e34c464 into main Jan 10, 2022
@danburck danburck deleted the ENG-373-Compile-build-in-contracts-in-the-build-process-IF-ETHERMINT-02 branch January 10, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danburck @fedekunze