-
Notifications
You must be signed in to change notification settings - Fork 563
fix: simulations don't generate EVM transactions #996
Conversation
Codecov Report
@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 60.93% 60.77% -0.17%
==========================================
Files 80 80
Lines 6594 6666 +72
==========================================
+ Hits 4018 4051 +33
- Misses 2365 2404 +39
Partials 211 211
|
This pull request introduces 1 alert when merging 0d2afd0 into edf4569 - view on LGTM.com new alerts:
|
…rations of SimulateEthCreateContract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Muggle-Du can you fix the linter and build errors?
Sure, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Added more comments. Currently missing:
Features
changelog entry- tests for the new
Random...
functions - tests for the simulation package functions, specially decoder
- update Github actions to run the simulation
- define
RandomizedParams
inx/evm/module.go
- update godoc comments
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Closes: #658
Description
Now the evm module doesn't generate random evm txs for the application simulation.
Generally speaking, we should implement the method
WeightedOperations
for x/evm module by generating random EthereumTx messages so that we can apply random evm txs to the module when we call theSimulateFromSeed
. When implementingWeightedOperations
, we can retrieve previous randomEthAccount
from auth module'sAccoutKeeper
.By default, auth module will only generate genesis base accounts and vesting accounts in simulation. But we can pass in custom
RandomGenesisAccounts
when initializing the application'sSimulationManager
so that we can generate genesisEthAccount
and other account types for simulation.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)