Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: web3 rpc api returns wrong block gas limit #782

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Problem: web3 rpc api returns wrong block gas limit #782

merged 4 commits into from
Nov 25, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 25, 2021 •
edited
Loading

Closes: #777

Solution:

  • pass in specific block height to the query

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

yihuang
yihuang commented Nov 25, 2021
View reviewed changes
rpc/ethereum/types/utils.go Outdated Show resolved Hide resolved
@crypto-facs crypto-facs mentioned this pull request Nov 25, 2021
Merged
11 tasks
@yihuang
Problem: web3 rpc api returns wrong block gas limit
7ed3f47 
Closes: evmos#777

Solution:
- pass in specific block height to the query
@yihuang yihuang force-pushed the fix-consensus-params branch from c354b50 to 7ed3f47 Compare November 25, 2021 06:58
@codecov
Copy link

codecov bot commented Nov 25, 2021 •
edited
Loading

Codecov Report

Merging #782 (b678e9d) into main (2bf2b67) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          71       71           
  Lines        6107     6107           
=======================================
  Hits         3509     3509           
  Misses       2396     2396           
  Partials      202      202
Impacted Files Coverage Δ
rpc/ethereum/types/utils.go 0.00% <0.00%> (ø)

leejw51crypto
leejw51crypto approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fedekunze
fedekunze approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK can you add a changelog entry?

@yihuang
Copy link
Contributor Author

yihuang commented Nov 25, 2021

ACK can you add a changelog entry?

sure, done.

@fedekunze fedekunze added backport/0.17.x PR scheduled for inclusion in the v0.17's next stable release backport/0.16.x PR scheduled for inclusion in the v0.16's next stable release labels Nov 25, 2021
@fedekunze fedekunze enabled auto-merge (squash) November 25, 2021 11:27
@fedekunze fedekunze merged commit 32eaec8 into evmos:main Nov 25, 2021
@yihuang yihuang deleted the fix-consensus-params branch November 25, 2021 11:45
@crypto-facs crypto-facs mentioned this pull request Nov 25, 2021
Closed
leejw51crypto pushed a commit to leejw51crypto/ethermint that referenced this pull request Nov 30, 2021
@yihuang @leejw51crypto
fix: web3 rpc api returns wrong block gas limit (evmos#782)
ba4eaee 
* Problem: web3 rpc api returns wrong block gas limit

Closes: evmos#777

Solution:
- pass in specific block height to the query

* Apply suggestions from code review

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
backport/0.16.x PR scheduled for inclusion in the v0.16's next stable release backport/0.17.x PR scheduled for inclusion in the v0.17's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: web3 rpc api returns wrong block gas limit
4 participants
@yihuang @fedekunze @leejw51crypto @thomas-nguy