Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

RPC tests are failing if FeeMarket Base Fee is enabled by default #770

Merged
merged 5 commits into from
Nov 23, 2021

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Nov 22, 2021

Closes: ENG-273 RPC tests are failing if FeeMarket Base Fee is enabled by default

Description

This PR enables the FeeMarket BaseFee by default and fixes the failing rpc tests by replacing the hardcoded gasPrice

@linear
Copy link

linear bot commented Nov 22, 2021

@danburck danburck marked this pull request as draft November 22, 2021 15:49
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #770 (6289ba4) into main (be8fd86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          71       71           
  Lines        6107     6107           
=======================================
  Hits         3509     3509           
  Misses       2396     2396           
  Partials      202      202           
Impacted Files Coverage Δ
x/feemarket/types/params.go 97.43% <100.00%> (ø)

@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Nov 23, 2021
@danburck
Copy link
Contributor Author

Thanks to @crypto-facs for finding the fix and removed the hardcoded gasPrice . Ready for review

@danburck danburck marked this pull request as ready for review November 23, 2021 14:36
@danburck danburck changed the title Fix(FeeMarket): Enable FeeMarkat BaseFee RPC tests are failing if FeeMarket Base Fee is enabled by default Nov 23, 2021
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fedekunze fedekunze enabled auto-merge (squash) November 23, 2021 14:52
@fedekunze fedekunze merged commit 2bf2b67 into main Nov 23, 2021
@fedekunze fedekunze deleted the ENG-273-rpc-tests-fail-with-enabled-FeeMarket-BaseFee branch November 23, 2021 15:00
fedekunze added a commit that referenced this pull request Nov 23, 2021
* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>
fedekunze added a commit that referenced this pull request Dec 1, 2021
* release: `v0.8.0` changelog (#757)

* release: v0.8.1 changes (#775)

* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>
fedekunze added a commit that referenced this pull request Dec 1, 2021
* release: `v0.8.0` changelog (#757)

* release: v0.8.1 changes (#775)

* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog `v0.8.1` (#805)

* release: `v0.8.0` changelog (#757)

* release: v0.8.1 changes (#775)

* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>
fedekunze added a commit that referenced this pull request Dec 1, 2021
* release: changelog `v0.9.0` (#806)

* release: `v0.8.0` changelog (#757)

* release: v0.8.1 changes (#775)

* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog `v0.8.1` (#805)

* release: `v0.8.0` changelog (#757)

* release: v0.8.1 changes (#775)

* docs: update changelog (#765)

* feemarket: unit tests EIP1559 (#758)

* Fee-Market(Types): Setup Params tests

* Fee-Market(Types): Add all Params tests

* Fee-Market(Types): Add genesis tests

* Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests

* Fee-Market(Keeper): Add Keeper tests

* Fee-Market(Keeper): Add review comments

* Fee-Market(Keeper): WIP grpc tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests

* Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee

* Fee-Market(Keeper): Add last ERIP1559 tests

* Fee-Market(Keeper): Add abci tests

* rpc: fix default signer (#769)

* rpc: fix default signer

* changelog

* build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770)

* Fix(FeeMarket): Enable FeeMarkat BaseFee

* fix rpc tests

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* changelog

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>

* docs: backport changelog updates

* unreleased

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Freddy Caceres <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants