Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Decode raw transaction via RLP #727

Merged
merged 3 commits into from Nov 8, 2021
Merged

Decode raw transaction via RLP #727

merged 3 commits into from Nov 8, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2021

Description

#714 removed MsgEthereumTx support in TxConfig, so cannot use TxConfig to decode raw transactions.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ghost ghost requested review from fedekunze, jolube and khoslaventures as code owners November 8, 2021 04:07
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rpc/ethereum/namespaces/eth/api.go Outdated Show resolved Hide resolved
rpc/ethereum/namespaces/eth/api.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) November 8, 2021 08:19
@fedekunze fedekunze merged commit fd36873 into evmos:main Nov 8, 2021
@ghost ghost deleted the nervemore/send-raw-transaction branch November 8, 2021 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant