This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 563
fix(rpc): align query result of future block for eth_getTransactionCount #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
force-pushed
the
query_future_acc
branch
from
January 26, 2023 03:13
c3f807b
to
1ffb622
Compare
mmsqe
requested review from
Vvaradinov and
danburck
and removed request for
a team
January 26, 2023 03:13
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
=======================================
Coverage 68.19% 68.20%
=======================================
Files 112 112
Lines 10155 10167 +12
=======================================
+ Hits 6925 6934 +9
- Misses 2825 2827 +2
- Partials 405 406 +1
|
MalteHerrmann
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thanks for aligning the behaviours @mmsqe! Left two small suggestions for more verbosity
Co-authored-by: MalteHerrmann <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>
mmsqe
added a commit
to mmsqe/ethermint
that referenced
this pull request
Mar 14, 2023
…unt (evmos#1638) * add future height check for get_transaction_count * add query future account test * fasten get_transaction_count test * add change doc * fix test * update nix * Update CHANGELOG.md Co-authored-by: MalteHerrmann <[email protected]> * Update rpc/backend/account_info.go Co-authored-by: MalteHerrmann <[email protected]> * update nix * add test for block height in future Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: MalteHerrmann <[email protected]>
11 tasks
mmsqe
added a commit
to crypto-org-chain/ethermint
that referenced
this pull request
Mar 14, 2023
…unt (evmos#1638) (#225) * add future height check for get_transaction_count * add query future account test * fasten get_transaction_count test * add change doc * fix test * update nix * Update CHANGELOG.md * Update rpc/backend/account_info.go * update nix * add test for block height in future Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: MalteHerrmann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Get a future block number 20000000 (0x1312d00) and a address that has a transaction count of 0:
Current Result:
{"id":0,"result":"0x0","jsonrpc":"2.0"}
Align with result when get a future block number 20000000 (0x1312d00) and an address with a non-zero transaction count:
Result:
{"id":0,"error":{"code":-32000,"message":"rpc error: code = Unknown desc = codespace sdk code 26: invalid height: cannot query with height in the future; please provide a valid height","data":null},"jsonrpc":"2.0"}
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)