Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(evm): revert v4 migration changes #1625

Merged
merged 8 commits into from
Jan 23, 2023
Merged

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review January 23, 2023 17:01
@fedekunze fedekunze requested a review from a team as a code owner January 23, 2023 17:01
@fedekunze fedekunze requested review from Vvaradinov and GAtom22 and removed request for a team January 23, 2023 17:01
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1625 (53299ea) into main (f07b14f) will increase coverage by 0.02%.
The diff coverage is 72.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
+ Coverage   68.15%   68.17%   +0.02%     
==========================================
  Files         112      112              
  Lines       10141    10157      +16     
==========================================
+ Hits         6912     6925      +13     
- Misses       2825     2827       +2     
- Partials      404      405       +1     
Impacted Files Coverage Δ
x/evm/migrations/v5/migrate.go 85.71% <25.00%> (-6.40%) ⬇️
x/evm/migrations/v4/migrate.go 77.77% <82.35%> (+17.77%) ⬆️
x/evm/types/params.go 87.32% <100.00%> (ø)

@fedekunze fedekunze enabled auto-merge (squash) January 23, 2023 17:36
@fedekunze fedekunze merged commit 9bfa1ff into main Jan 23, 2023
@fedekunze fedekunze deleted the fedekunze/params-migration branch January 23, 2023 17:51
@MalteHerrmann
Copy link
Contributor

https://github.com/Mergifyio backport release/v0.21.x

@mergify
Copy link
Contributor

mergify bot commented Jan 23, 2023

backport release/v0.21.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 23, 2023
* fix(evm): revert v4 migration changes

* add check for chainID

* fix: renamed vars to avoid duplicate proto

* test

* fix: set default extraEIPs to nil

* fix: updated tests

Co-authored-by: Vladislav Varadinov <[email protected]>
(cherry picked from commit 9bfa1ff)
MalteHerrmann pushed a commit that referenced this pull request Jan 23, 2023
* fix(evm): revert v4 migration changes

* add check for chainID

* fix: renamed vars to avoid duplicate proto

* test

* fix: set default extraEIPs to nil

* fix: updated tests

Co-authored-by: Vladislav Varadinov <[email protected]>
(cherry picked from commit 9bfa1ff)

Co-authored-by: Federico Kunze Küllmer <[email protected]>
fedekunze added a commit that referenced this pull request Jan 25, 2023
* release: v0.21.0-rc1 changelog (#1606)

* changelog: added rc-1 changelog entry

* fix: typo fix rc1

* fix(rpc): bind default json-rpc listen address to localhost (backport #1613) (#1621)

* fix(rpc): bind default json-rpc listen address to localhost (#1613)

* update nix

* bind default json-rpc to 127.0.0.1

* add change doc

* Update CHANGELOG.md

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 3587015)

# Conflicts:
#	CHANGELOG.md

* address merge conflicts

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>

* fix(rpc): align fee history (backport #1611) (#1620)

* fix(rpc): align fee history (#1611)

* update nix

* add next fee in fee history

* fix test

* add change doc

* height + 1 for next fee

* cross check baseFeePerGas len

* Update tests/integration_tests/test_fee_history.py

Co-authored-by: MalteHerrmann <[email protected]>

* fix oldestBlock & align earliest input as eth

* update doc

* update nix

* isort test_fee_history.py

* fix test

* align rpc res as eth

* add cross check

* add baseFeePerGas len check

* add oldestBlock check

Co-authored-by: MalteHerrmann <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 47fdfd3)

# Conflicts:
#	CHANGELOG.md

* address merge conflicts

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* support customize db opener in `StartCmd` (backport #1615) (#1622)

* support customize db opener in `StartCmd` (#1615)

* support customize db opener in `StartCmd`

* Update CHANGELOG.md

* pass  to dbOpener, so we can control different options through cli flags

* add comments

(cherry picked from commit f1337aa)

# Conflicts:
#	CHANGELOG.md

* conflicts

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* tests(evm): add benchmark tests setup for params (#1623) (#1627)

* tests: add benchmark tests setup

* fix: localized benchmark tests to keeper

* update benchmark

Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 9305788)

Co-authored-by: Vladislav Varadinov <[email protected]>

* refactor(params): store all params under one key in evm module (backport #1617) (#1626)

* refactor(params): store all params under one key in evm module (#1617)

* refactor(params): store all params under one key in evm module

* refactor(params): add changelog entry

* refactor(params): update based on review comments. Remove params getter functions

* refactor(params): refactor params store key

* refactor(params): remove unnecessary store keys

* refactor(params): add paramSetPairs for backwards compatibility

* Update CHANGELOG.md

* refactor(params): add license to params_legacy file

* Apply suggestions from code review

* fix(evm): handle RC1 params during migration (#1624)

* fix(evm): handle RC1 params during migration

* migration

* fix: test case updated for RC1

* v5 migration

* tests

* tests pt2

* comment

* execute make proto-all

Co-authored-by: Vladislav Varadinov <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>

* Apply suggestions from code review

* rm dup vars

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Vladislav Varadinov <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>
(cherry picked from commit f07b14f)

# Conflicts:
#	CHANGELOG.md

* update changelog

Co-authored-by: Tomas Guerra <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>
Co-authored-by: MalteHerrmann <[email protected]>

* fix(evm): revert v4 migration changes (#1625) (#1628)

* fix(evm): revert v4 migration changes

* add check for chainID

* fix: renamed vars to avoid duplicate proto

* test

* fix: set default extraEIPs to nil

* fix: updated tests

Co-authored-by: Vladislav Varadinov <[email protected]>
(cherry picked from commit 9bfa1ff)

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* minor improvement to changelog (#1629)

* adjust year to 2023 for v0.21.0-rc2 release (#1630)

* Update CHANGELOG.md

Co-authored-by: Vladislav Varadinov <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Tomas Guerra <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants