-
Notifications
You must be signed in to change notification settings - Fork 563
chore(evm, feemarket) - Migrate Event emitting to TypedEvent #1544
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 68.52% 68.40% -0.12%
==========================================
Files 106 106
Lines 10077 10077
==========================================
- Hits 6905 6893 -12
- Misses 2775 2783 +8
- Partials 397 401 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Vvaradinov! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK minor comments
…com/evmos/ethermint into Vvaradinov/evm-migrate-typed-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM, left some minor nit-picking on some comments but that's personal preference really.
@Vvaradinov there are some failing tests though, which seem to reference some of the affected events (e.g. block bloom event is not found
in this run) - can you either verify that this is not caused by the changes here or adjust the tests accordingly?
…vmos#1544)" This reverts commit 8886ce3.
Description
Migrate the usage of now deprecated
EmitEvent
toEmitTypedEvent
. Newevents.proto
is created describing each event type theevm
module emits. Marked with aTODO
a place where I am unsure how to proceed.Closes: ENG-1173
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)