-
Notifications
You must be signed in to change notification settings - Fork 563
imp(rpc,server): concurrent gRPC queries #1352
Conversation
Solution: - Initiate the GRPCClient introduced in [sdk 0.46](cosmos/cosmos-sdk#11234).
Co-authored-by: Federico Kunze Küllmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Verified manually that it indeed worked (by adding a long sleep in one of the grpc query handlers).
Does this need any additional documentation? Would be nice to add some concurrent query test cases in the JSON-RPC
may need a very slow |
@yihuang can you look into the failing integration tests? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 54.77% 54.77%
=======================================
Files 107 107
Lines 9994 9994
=======================================
Hits 5474 5474
Misses 4249 4249
Partials 271 271
|
Integration test fixed, but the panic causing node to crash need further investigation, probably at sdk level |
Closes: #1007
Description
Verified manually that it indeed worked (by adding a long sleep in one of the grpc query handlers).
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)