-
Notifications
You must be signed in to change notification settings - Fork 563
Create LedgerPreprocessHook to reformat EIP-712 payloads #1277
Conversation
This pull request introduces 1 alert when merging d897959 into f11bc35 - view on LGTM.com new alerts:
|
d897959
to
6dea312
Compare
This pull request introduces 1 alert when merging 6dea312 into c9fe1d1 - view on LGTM.com new alerts:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
- Coverage 56.53% 54.78% -1.75%
==========================================
Files 105 107 +2
Lines 9609 9984 +375
==========================================
+ Hits 5432 5470 +38
- Misses 3912 4243 +331
- Partials 265 271 +6
|
This pull request introduces 1 alert when merging ac17f58 into c9fe1d1 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bbcec73 into 45fdcaf - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@austinchandra LGTM, left some comments on how to approve the comments.
…/ethermint into develop/eip712/reformat-tx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, left a comment about supporting multisigs. Can you add a feature changelog entry?
Closes: #XXX
Description
This PR implements the Ledger EIP-712 preprocessing required to format EIP-712 transactions for verification, by including the signature information in a
Web3Tx
extension, setting the signature in the tx body to be blank, and setting the SignMode to beLEGACY_AMINO
for Ledger-signed transactions.This preprocessing will be performed on each transaction submitted via the CLI; however, all non-Ledger interactions should short-circuit.
This must be modified (if not completely removed) when an Evmos Ledger app becomes available, as that would not benefit from this preprocessing.
Tests
Test Coverage:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)