Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix account type method #1118

Merged
merged 2 commits into from
Jun 8, 2022
Merged

fix account type method #1118

merged 2 commits into from
Jun 8, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

Fix empty code hash comparison on account Type() method


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1118 (d5ad136) into main (b567624) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d5ad136 differs from pull request most recent head 1dc5642. Consider uploading reports for the commit 1dc5642 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          88       88           
  Lines        7285     7285           
=======================================
  Hits         4507     4507           
  Misses       2557     2557           
  Partials      221      221           
Impacted Files Coverage Δ
types/account.go 26.31% <100.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit b3fa23e into evmos:main Jun 8, 2022
fedekunze added a commit that referenced this pull request Jun 8, 2022
* build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (#1115)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* tests: update consensus params (#1117)

* tests: update consensus params

* fix

* fix(types): account type method (#1118)

* fix account type method

* update changelog

* update changelog

* update changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Jun 10, 2022
* fix account type method

* update changelog
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
* build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (evmos#1115)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* tests: update consensus params (evmos#1117)

* tests: update consensus params

* fix

* fix(types): account type method (evmos#1118)

* fix account type method

* update changelog

* update changelog

* update changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants