Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: need to add rpc endpoint personal_unpair #730

Closed
adu-web3 opened this issue Nov 9, 2021 · 0 comments · Fixed by #733
Closed

Problem: need to add rpc endpoint personal_unpair #730

adu-web3 opened this issue Nov 9, 2021 · 0 comments · Fixed by #733
Labels
C:JSON-RPC JSON-RPC client

Comments

@adu-web3
Copy link
Contributor

adu-web3 commented Nov 9, 2021

Unpair deletes a pairing between wallet and geth
It's mainly involved with smartcard wallet, refer to: https://github.com/gballet/go-ethereum/blob/0d36c04ccf1d000ed16b2aaf419d2e01eaf85406/accounts/scwallet/README.md
there is no corresponding personal_unpair rpc endpoint in ethermint, need to add

@adu-web3 adu-web3 changed the title Problem: need to add rpc endpoint personal_Unpair Problem: need to add rpc endpoint personal_unpair Nov 9, 2021
@fedekunze fedekunze added the C:JSON-RPC JSON-RPC client label Nov 9, 2021
adu-web3 added a commit to adu-web3/ethermint that referenced this issue Nov 9, 2021
Closes evmos#730

* this is aimed at smartcard wallet which is not supported yet.

* will return unsupported error now.
fedekunze added a commit that referenced this issue Nov 10, 2021
* Problem: need to add rpc endpoint personal_unpair

Closes #730

* this is aimed at smartcard wallet which is not supported yet.

* will return unsupported error now.

* Update rpc/ethereum/namespaces/personal/api.go

* add changelog entry and use errors.Is

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants