Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

balance overflow int64 #218

Closed
yihuang opened this issue Jul 2, 2021 · 0 comments · Fixed by #219
Closed

balance overflow int64 #218

yihuang opened this issue Jul 2, 2021 · 0 comments · Fixed by #219

Comments

@yihuang
Copy link
Contributor

yihuang commented Jul 2, 2021 •
edited
Loading

System info: ethermint main branch

Steps to reproduce:

  1. Set balance of genesis account to 10000000000000000000000aphoton
  2. start devnet and query balance
>>> w3.eth.getBalance('0x32A079939Faf05b09798d517Ae4603632c71d432')
1864712049423024128
>>> 10000000000000000000000 % (2**64)
1864712049423024128

Probably due to https://github.com/tharsis/ethermint/pull/208/files#diff-0ceec127cab538366d521200eff10d764791b12d19af704a6b4b01e876a90210R39 changed String to int64?

Expected behavior: don't overflow

Actual behavior: overflow
@yihuang yihuang mentioned this issue Jul 2, 2021
Merged
11 tasks
yihuang referenced this issue in yihuang/ethermint Jul 2, 2021
@yihuang
fix balance overflow in rpc response
40981c8 
Closes #218
fedekunze pushed a commit that referenced this issue Jul 2, 2021
@yihuang
rpc: fix balance overflow (#219)
6e983a9 
Closes #218
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix balance overflow in rpc response yihuang/ethermint
1 participant
@yihuang