Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming various changes from fork #36

Open
connorjclark opened this issue Sep 28, 2020 · 1 comment
Open

Upstreaming various changes from fork #36

connorjclark opened this issue Sep 28, 2020 · 1 comment

Comments

@connorjclark
Copy link

connorjclark commented Sep 28, 2020

Hi Evan!

The Lighthouse team forked this repo: https://github.com/paulirish/webtreemap-cdt

We will be using webtreemap for a new feature in Lighthouse, @paulirish is also working on a new feature in Chrome DevTools that uses it too.

We made a few changes in that fork:

a) webpack -> rollup (not necessary to upstream imo)
b) add option for not injecting CSS with JS
c) split out a public layout() method
d) a11y: keyboard navigation
e) options.spacing

Would you be open to receiving some PRs for upstreaming these changes?

@evmar
Copy link
Owner

evmar commented Oct 20, 2020

Thanks for reaching out, and sorry I am so slow to respond! I filed #37 about the future of this project, and I'd love your feedback there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants