support null hdcSrc when using BLACKNESS rop #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evmar
reviewed
Sep 14, 2024
| @@ -152,6 +152,11 @@ pub fn BitBlt( | |||
| y1: i32, | |||
| rop: u32, | |||
| ) -> bool { | |||
| if rop == BLACKNESS { | |||
| // It seems like passing null as `hdcSrc` when using BLACKNESS is supported on Windows. | |||
There was a problem hiding this comment.
Looking at the docs, it's plausible to me that maybe all of the modes that don't involve one of the SRC* variants don't care about hdcsrc?
(You don't need to change this, just thinking out loud)
There was a problem hiding this comment.
...also, sorry for my terrible clunky bitmap code, I still don't have the right mental model about how it ought to work for me to write it better :(
There was a problem hiding this comment.
Yeah, it was a bit hard to follow the code, but I don't really know how to do it better 😅
First I started wrapping the source in an Option but it became very messy, not sure how to best do this 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.