Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes arg writing to incorrect scope; statuses now work. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amovitz
Copy link

@amovitz amovitz commented Feb 6, 2018

By default, all pages responded with 200.
This patch fixes the problem with statuses always responding with 200, regardless of the status set in the program.

@evilsocket
Copy link
Owner

Your PR did not change or fix anything, you just renamed a variable.

@evilsocket evilsocket closed this Feb 7, 2018
@amovitz
Copy link
Author

amovitz commented Feb 7, 2018

The variable change is the fix.
With the current state of the code, compile it with an example that should send a 200 on one route and a 400 on another. Both routes will always return a 200. Your code is compiling with a variable scope that sets itself. Example:
int i
void foo(int i) {
i = i; //i (the externale variable) is never set.
//This sets the i inside of the function scope.
}

@evilsocket evilsocket reopened this Feb 7, 2018
@evilsocket
Copy link
Owner

will try to reproduce and update you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants