Fix bug causing errors to be cleared when using autoProgress #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values When setting a value for an input, we re run validation for any fields that have errors. This was reading from the errors state directly which can be out of date if called in the middle of a render. By using the setErrors callback syntax we will get the most up to date values. I've also removed a line which skipped validating the current field in this setValue call. I'm not sure why this existed in the first place.
🦋 Changeset detectedLatest commit: 523707f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dave-kav
approved these changes
Feb 11, 2025
thomascullen
deleted the
thomas/etr-3035-validation-doesnt-occur-when-autoprogress-is-set-to-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a value for an input, we re run validation for any fields that have errors. This was reading from the errors state directly which can be out of date if called in the middle of a render. By using the setErrors callback syntax we will get the most up to date values.
I've also removed a line which skipped validating the current field in this setValue call. I'm not sure why this existed in the first place.