Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storybook DocsPage for Vue #6

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

shilman
Copy link

@shilman shilman commented Nov 17, 2019

I added Storybook DocsPage which will ship with first-class Vue support in 5.3.

Alert_-_Defaults_⋅_Storybook

If we can improve the docs a bit, I'd like to use this as an example in the Storybook 5.3 release.

A few things I'm hoping to add:

Thanks to @Aaron-Pool @pocka @elevatebart for help out!

@shilman shilman changed the title Add Storybook DocsPage Add Storybook DocsPage for Vue Nov 17, 2019
@shilman
Copy link
Author

shilman commented Nov 17, 2019

@Aaron-Pool FYI I tried to add an MDX intro story and ran into the following error, which reminds me of this problem we ran into in the MDX storyshots PR: storybookjs/storybook#8557 (comment)

Error: This API has been removed. If you're looking for this functionality in Babel 7, you should import the '@babel/helper-module-imports' module and use the functions exposed from that module, such as 'addNamed' or 'addDefault'.
at File.addImport
...

I'll open a separate PR for that after this one gets merged and it would be great if we could get to the bottom of it. MDX is working in Storybook's vue-kitchen-sink example somehow.

@shilman
Copy link
Author

shilman commented Nov 23, 2019

@Aaron-Pool I added in subcomponents. ButtonGroup/Button works:

buttongroup-lg

Unfortunately, AlertIcon, AlertTitle, AlertDescription don't seem to have docgen info. Is this something you might be able to look into?

@Aaron-Pool
Copy link

@shilman yup, I'll try to get to that today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants