-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storybook DocsPage for Vue #6
base: master
Are you sure you want to change the base?
Conversation
@Aaron-Pool FYI I tried to add an MDX intro story and ran into the following error, which reminds me of this problem we ran into in the MDX storyshots PR: storybookjs/storybook#8557 (comment)
I'll open a separate PR for that after this one gets merged and it would be great if we could get to the bottom of it. MDX is working in Storybook's |
@Aaron-Pool I added in subcomponents. Unfortunately, |
@shilman yup, I'll try to get to that today! |
I added Storybook DocsPage which will ship with first-class Vue support in 5.3.
If we can improve the docs a bit, I'd like to use this as an example in the Storybook 5.3 release.
A few things I'm hoping to add:
AlertIcon
,AlertTitle
,AlertDescription
) (coming in Addon-docs: Multi-component props tables on DocsPage storybookjs/storybook#7811)Thanks to @Aaron-Pool @pocka @elevatebart for help out!