Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drag n Drop Reordering to ResponsiveTable Component #1662

Merged
merged 23 commits into from
Oct 4, 2019
Merged

Add Drag n Drop Reordering to ResponsiveTable Component #1662

merged 23 commits into from
Oct 4, 2019

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Oct 4, 2019

Problem this Pull Request solves

Closes #1527

How has this been tested

monkey based browser testing only

tn3rb added 21 commits October 3, 2019 17:11
@tn3rb
install react-beautiful-dnd
688834b
@tn3rb
useReorderEntities - hook for setting custom order of entity list
4e4a2b8
@tn3rb
pass through entity ID list and setter for sorting list order
2f81d0f
@tn3rb
cache menuItems in state and set after render if empty
781aa99
@tn3rb
move logic into ticketsListTableRow where it's actually used
27c4145
@tn3rb
extra comment regarding order value
fefddae
@tn3rb
add useReorderTickets and use in EditorTicketEntitiesListView
3729137
@tn3rb
add useReorderDates and use in EditorDateEntitiesListView
68026c6 
move logic into datesListTableRow where it's actually used
@tn3rb
bunch of css tweaks
eb8fd2a
@tn3rb
implement react-beautiful-dnd
1c31273
@tn3rb
fix dependencies
1922c9c
@tn3rb
fix jsdocs
a0aec80
@tn3rb
pass model name so that entities can be verified
3a6785e
@tn3rb
move logic from ResponsiveTable into table subcomponents
3fcfc5e
@tn3rb
fix table data schema; rename component
4f50aa5
@tn3rb
update components and table data schema after ResponsiveTable changes
891ddf2
@tn3rb
fix render cycling
ca4e96b
@tn3rb
fix property name after change
5f5e35e
@tn3rb
pass model name to useReorderEntities
ff57db2
@tn3rb
use filtered entity ID lists to set keys on components
fc55a0c
@tn3rb
tweak date ID position js_only
57339db
@tn3rb tn3rb assigned ghost Oct 4, 2019
@tn3rb tn3rb requested a review from a user October 4, 2019 00:15
@tn3rb tn3rb added this to the EDTR v1 milestone Oct 4, 2019
@ghost ghost added the status:merge label Oct 4, 2019
@tn3rb tn3rb merged commit f7a7bc5 into EDTR/refactor-master Oct 4, 2019
@tn3rb tn3rb deleted the EDTR/drag-n-drop-tables branch October 4, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
category:admin-page-ui-&-ux category:assets type:enhancement 🎉
Projects
None yet
Milestone
EDTR v1
Development

Successfully merging this pull request may close these issues.
1 participant
@tn3rb