filter out the empty venues #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have no venue selected in a event, the `$venues` array still returns 1 element which is `null`. Applying a `array_filter()` on `$venues` removes empty values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have no venue selected in a event, the
$venuesarray still returns 1 element which isnull. Applying aarray_filter()on$venuesremoves empty values.Problem this Pull Request solves
Within the shortcode
[ESPRESSO_MY_EVENTS]a venue is shown. However, if no venue is configured for a event, the code will crash because it tries to perform actions on the$venueobject. By filtering the empty values in$venues, this problem will not occur.How has this been tested
Visiting the page where
[ESPRESSO_MY_EVENTS]is executed.Checklist
esc_html__(), see https://codex.wordpress.org/I18n_for_WordPress_Developers)