Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore type checking when using properties #24

Merged
merged 2 commits into from
Jul 30, 2019
Merged

ignore type checking when using properties #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f13645
ignore type checking when using properties
Jul 30, 2019
3f33592
don't run mypy on python 3.4
Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ install:
- pip install -e .[testing]
- if [[ $TRAVIS_PYTHON_VERSION == 3* ]]; then pip install mypy flake8; fi
script:
- if [[ $TRAVIS_PYTHON_VERSION == 3* ]]; then mypy .; fi
- if [[ $TRAVIS_PYTHON_VERSION == 3* && $TRAVIS_PYTHON_VERSION != "3.4" ]]; then mypy .; fi
- pytest --cov=facebook_sdk tests
after_success:
- coveralls
Expand Down
4 changes: 2 additions & 2 deletions facebook_sdk/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def __init__(
graph_version = graph_version or DEFAULT_GRAPH_VERSION

self.app = app
self.access_token = access_token
self.access_token = access_token # type: ignore
self.method = method
self.endpoint = endpoint
self.graph_version = graph_version # type: Text
Expand All @@ -77,7 +77,7 @@ def __init__(

@property
def endpoint(self): # type: () -> Text
return self._endpoint
return self._endpoint # type: ignore

@endpoint.setter
def endpoint(self, value): # type: (Text) -> None
Expand Down