Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dfs): make DFS more efficient by using IndexMap rather than Vec #553

Closed
wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Collaborator

This causes an API change as using an IndexMap requires the type to implement Hash.

Copy link

codspeed-hq bot commented Mar 24, 2024

CodSpeed Performance Report

Merging #553 will degrade performances by 19.93%

Comparing better-dfs (3464e58) with main (e32db8c)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main better-dfs Change
fill-corner_to_corner_dfs 4.5 ms 2.1 ms ×2.1
fill-corner_to_corner_dijkstra 1.3 ms 1.7 ms -19.93%
corner_to_corner_dfs 31.5 ms 1.7 ms ×18
corner_to_corner_dijkstra 1.9 ms 1.6 ms +16.04%

This requires an API change as using an `IndexSet` requires the type to
implement `Hash`.
@samueltardieu
Copy link
Collaborator Author

Code change is moot

@samueltardieu samueltardieu deleted the better-dfs branch September 5, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant