Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huawei EMMA template #16665

Closed
wants to merge 4 commits into from
Closed

Huawei EMMA template #16665

wants to merge 4 commits into from

Conversation

Mungg1818
Copy link
Contributor

Made template for Huawei EMMA device

@Mungg1818 Mungg1818 changed the title Feature/huawei emma template Huawei EMMA template Oct 15, 2024
andig
andig reviewed Oct 15, 2024
View reviewed changes
templates/definition/meter/huawei-emma.yaml
id: 0
uri: {{ .host }}:{{ .port }}
timeout: {{ .timeout }}
connectdelay: 1s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wie meinst du das? Bzgl. des Templates oder speziefischer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Delay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe das Smartlogger Template als Basis genommen und die Modbus Adressen angepasst. Weiter habe ich nichts hinterfragt. Ich kanns Testen ob es auch ohne das Delay funktioniert.
Was bewirkt dieses genau?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ein unnützes Delay, bitte raus damit.

@andig andig added the devices Specific device support label Oct 15, 2024
andig
andig reviewed Oct 16, 2024
View reviewed changes
templates/definition/meter/huawei-emma.yaml
- name: usage
choice: ["grid", "pv", "battery"]
allinone: true
- name: storageunit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wozu brauchts das?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wird dies für das Battery Control gebraucht? Dann würde ich es noch drin lassen und mich danach and die Steuerung setzen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn es nicht benutzt wird bitte raus

andig
andig reviewed Oct 16, 2024
View reviewed changes
templates/definition/meter/huawei-emma.yaml
source: modbus
id: 0
uri: {{ .host }}:{{ .port }}
timeout: {{ .timeout }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito- raus falls nicht notwendig

andig
andig reviewed Oct 16, 2024
View reviewed changes
templates/definition/meter/huawei-emma.yaml
advanced: true
- name: modbus
choice: ["tcpip"]
- name: timeout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raus

@andig
Copy link
Member

andig commented Oct 16, 2024

...und hat das Ding wirklich Modbus ID 0?

@andig andig marked this pull request as draft October 16, 2024 21:19
@github-actions github-actions bot added the stale Outdated and ready to close label Oct 23, 2024
@github-actions github-actions bot closed this Oct 28, 2024
@swenro
Copy link

swenro commented Nov 18, 2024

Made template for Huawei EMMA device

Hey, wie binde ich das template ein? Oder kommt das erst mit einem Update?

Bekomme diese Fehlermeldung:
"cannot create meter 'my_grid': cannot create meter type 'template': template not found: huawei-emma"

Oder habe ich etwas falsch gemacht beim einbinden=
meters:

  • name: my_grid
    type: template
    template: huawei-emma
    usage: grid

    Modbus TCP

    modbus: tcpip
    id: 0
    host: 192.168.2.72 # Hostname
    port: 502 # Port
    timeout: 15s # optional

@andig
Copy link
Member

andig commented Nov 18, 2024

Template was never finished unfortunately. Review comments were not addressed.

@Mungg1818
Copy link
Contributor Author

Mungg1818 commented Nov 18, 2024 •
edited
Loading

Hey, ich hatte leider keine Zeit mehr um das Template noch zu korrigieren. Werde mich aber gleich jetzt hinsetzen und hoffe die Änderungen werden akzeptiert. Bei mir läufts seit Oktober auf einem Raspi.
Bzgl. der Modbus ID --> ja ich bin mir sicher dass Sie 0 sein muss.

@swenro
Copy link

swenro commented Nov 18, 2024

Das klingt super, ja die ID 0 hatte ich auch so rausgesucht, ich bekomme die EMMA nur nicht eingebunden und dachte ich finde hier die Lösung :-)

@Mungg1818
Copy link
Contributor Author

Mungg1818 commented Nov 18, 2024 •
edited
Loading

Leider konnte ich das battery control noch nicht hinzufügen, falls deine PV Anlage einen Speicher hat.

@swenro
Copy link

swenro commented Nov 18, 2024 •
edited
Loading

Ja, Speicher ist dran, wobei ich den Speicher über die id 4 schon auslesen konnte, nur "Grid" bekomme ich nicht eingebunden.

  - name: my_battery
    type: template
    template: huawei-sun2000
    usage: battery
    
    modbus: tcpip
    id: 4
    host: 192.168.2.72 # Hostname
    port: 502 # Port
    timeout: 15s # optional
    storageunit: 1 # optional
    capacity: 15 # Akkukapazität in kWh (optional)

@Mungg1818
Copy link
Contributor Author

Neuer PR ist raus. Huawei EMMA template #17338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

Assignees
No one assigned
Labels
devices Specific device support stale Outdated and ready to close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mungg1818 @andig @swenro