Ocpp: do not return error on setup #15853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Imho we should not configure this at all. |
|
We have to configure it if we want the chargers reconnect in time. |
|
I don't see any indication that this changes anything. The charger would already notice a dropped TCP connection afaikt, independently from the websocket ping. That's due to the fact that evcc continually sends messages to the charger (which is not the case with an idle websocket connected). The timeout does not do anything in our scenario imho. |
Closed
|
It is the station (CP) configuration, not CS. This makes the CP detect a loss of connection MUCH faster so it can reconnect in time. |
mabunixda
added a commit
to mabunixda/evcc
that referenced
this pull request
Sep 4, 2024
* master: Fix status reason ot updated (evcc-io#15873) Translations update from Hosted Weblate (evcc-io#15723) chore: upgrade libraries Fronius Wattpilot: re-add (evcc-io#15843) chore: upgrade dependencies Ocpp: do not return error on setup (evcc-io#15853) EEbus: only disable recommendations if available (evcc-io#15829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15852