Easee: never stop session, only pause charge #10077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User feedback on #9271 was given, that the change from pause to stop command is actually causing some annoyance. Background to this is, that stopping a charge, puts the charger back into the "unauthenticated" state. This has the side effect, that the LED strip on the charger starts blinking. Additionally when the charge is restarted later, the re-authentication is confirmed with an audible sound. When clouded weather is changing the charge status several times, this apparently becomes annoying to some.
This change simply removes the code path for the authenticated charger, that it uses stop command instead of pause. Using pause keeps the existing authentication, but this is OK, as it is sufficient to authenticate once on connection of a new vehicle. On disconnect the Easee de-authenticates anyways. For the charge (re)start this is also OK.
This change was tested already by me locally and is looking good to go.