Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #791: onResolve is not fired on entrypoints when namespace equals 'file' #799

Closed
wants to merge 1 commit into from
Closed

fix #791: onResolve is not fired on entrypoints when namespace equals 'file' #799

wants to merge 1 commit into from

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 12, 2021 •
edited
Loading

Close #791
normally esbuild default namespace is file, but in this commit, it seems it has been forgotten to set file as default.

@susiwen8
fix #791:
cdb63d3 
onResolve is not fired on entrypoints when namespace equals 'file'
@evanw
Copy link
Owner

evanw commented Feb 13, 2021

Sorry but I am not going to land this because the current behavior is by design. See #791 for details.

@susiwen8 susiwen8 closed this Feb 13, 2021
@susiwen8 susiwen8 deleted the 791 branch February 13, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onResolve is not fired on entrypoints when namespace equals 'file'
2 participants
@susiwen8 @evanw