Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call all js plugins onResolve and onLoad functions #552

Closed
wants to merge 6 commits into from
Closed

Call all js plugins onResolve and onLoad functions #552

wants to merge 6 commits into from

Conversation

remorses
Copy link
Contributor

@remorses remorses commented Nov 20, 2020 •
edited
Loading

This makes it possible to override previous plugins, previously only the first matching plugin onResolve and onLoad was called

Fix #501

@remorses
Copy link
Contributor Author

remorses commented Dec 4, 2020

Now plugins don't change the arguments passed to subsequent plugins anymore.

To enable data sharing between plugins maybe we could add a context argument that plugins can populate in a middleware like fashion, what do you think?

@remorses remorses closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call all plugins onResolve instead of using only the first one
1 participant
@remorses