Fix sourcemap path problem #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
force-pushed
the
fix-source-map
branch
from
da7f4e1 to
c5e67a7
Compare
|
Thanks for the pull request. I agree that this should be fixed, although I don't think this is the best way to do it. Or at least the real situation is more complicated. With the introduction of plugins there are also going to be modules that don't correspond to anything on disk at all. Attempting to interpret those module names as file system paths might lead to pretty confusing and incorrect results. So I'm going to land this now but I may change this and/or rewrite it in the future to better support additional use cases. |
evanw
added a commit
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #444
This is my first time writing about golang.
I'm sorry if you have any questions.