WIP: Add Flow syntax parsing #384
Conversation
internal/parser/parser.go
Outdated
| p.lexer.ExpectContextualKeyword("from") | ||
| p.parsePath() | ||
| p.lexer.ExpectOrInsertSemicolon() | ||
| return ast.Stmt{Loc: loc, Data: &ast.STypeScript{}} |
There was a problem hiding this comment.
This is copied from the TypeScript-specific section of the import parser. Should there be a separate AST type for Flow types? Or should this just emit a blank statement?
There was a problem hiding this comment.
I think STypeScript should be changed to something more generic such as SIgnoredType. The only purpose is to tell the caller to drop the statement. These statements never make it out of the parser.
|
I'm closing this since #79 is now closed. The context is that the Flow team recently announced that they are going to diverge from the JavaScript language and no longer be just JavaScript with types: https://medium.com/flow-type/clarity-on-flows-direction-and-open-source-engagement-e721a4eb4d8b. So Flow support now seems better-suited for an esbuild plugin than being built into esbuild itself. |
Work-in-progress implementation of Flow syntax support #79