Re-enable unref in Deno
#3701
Open
Re-enable unref in Deno
#3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-enables unref-by-default in Deno, and fixes the event loop starvation issue by explicitly re-ref'ing the esbuild sub-process when a user calls `stop()`.
lucacasonato
commented
Mar 15, 2024
Comment on lines
+214
to
+217
| // Ref the child process again, so that a user calling `close()` can await | ||
| // the returned promise without the event loop starving because there are | ||
| // no more ref'd async tasks. | ||
| child.ref() |
There was a problem hiding this comment.
This is the only new code. All other code is just a revert of 116f63e.
Comment on lines
+680
to
+684
| // You may also start esbuild once at the top level of your test suite (by | ||
| // calling `initialize()`) instead of starting and stopping the esbuild process | ||
| // for every test. This will not interfere with the resource sanitizer, and will | ||
| // improve the efficiency of your tests because the esbuild process can be | ||
| // reused between tests. |
There was a problem hiding this comment.
I have added this paragraph to explain that you may also start esbuild outside of a Deno.test call to avoid the resource sanitizer flagging it.
|
@evanw Could you take a look at this? |
marvinhagemeister
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables unref-by-default in Deno, and fixes the event loop starvation issue by explicitly re-ref'ing the esbuild sub-process when a user calls
stop().Background: #3682 (comment)